implement favorite button

This commit is contained in:
Carlos Martinez
2020-02-06 10:35:54 -03:00
parent e1616a7370
commit 1fa3f8c43d
20 changed files with 236 additions and 29 deletions

View File

@@ -2,7 +2,9 @@ package com.hako.userlist.di
import com.hako.base.domain.network.RemoteClient
import com.hako.userlist.domain.datasource.UserlistRemoteApi
import com.hako.userlist.domain.usecase.GetFavoriteUsers
import com.hako.userlist.domain.usecase.GetUsers
import com.hako.userlist.domain.usecase.SetFavoriteStatus
import com.hako.userlist.viewmodel.UserlistViewmodel
import org.koin.androidx.viewmodel.dsl.viewModel
import org.koin.dsl.module
@@ -10,6 +12,8 @@ import org.koin.dsl.module
val userlistModules = module {
factory { get<RemoteClient>().getClient(UserlistRemoteApi::class.java) }
factory { GetUsers(get()) }
factory { GetFavoriteUsers(get()) }
factory { SetFavoriteStatus(get()) }
viewModel { UserlistViewmodel() }
}

View File

@@ -0,0 +1,29 @@
package com.hako.userlist.domain.usecase
import com.hako.base.domain.database.dao.UserDao
import com.hako.userlist.model.UserViewable
import com.hako.userlist.model.toUserViewable
import io.reactivex.Single
import io.reactivex.schedulers.Schedulers
class GetFavoriteUsers(private val dao: UserDao) {
fun execute(
onSuccess: (List<UserViewable>) -> Unit,
onEmpty: () -> Unit,
onError: (Throwable) -> Unit
) {
Single.fromCallable { dao.getFavoriteUsers() }
.subscribeOn(Schedulers.io())
.doOnSuccess { dbUsers ->
if (dbUsers.isEmpty()) {
onEmpty()
} else {
onSuccess(dbUsers.map { it.toUserViewable() })
}
}
.doOnError { onError(it) }
.onErrorReturn { emptyList() }
.subscribe()
}
}

View File

@@ -17,7 +17,8 @@ class GetUsers(private val dao: UserDao) : KoinComponent {
fun execute(
onSuccess: (List<UserViewable>) -> Unit,
onError: (Throwable) -> Unit,
onLoading: () -> Unit
onLoading: () -> Unit,
onEmpty: () -> Unit
) {
Single.fromCallable { dao.getAllUsers() }
.subscribeOn(Schedulers.io())
@@ -26,8 +27,12 @@ class GetUsers(private val dao: UserDao) : KoinComponent {
if (dbUsers.isEmpty()) {
api.getUsers()
.doOnSuccess {
dao.saveAll(it.map { user -> user.toUserEntity() })
onSuccess(dao.getAllUsers().map { user -> user.toUserViewable() })
if (it.isEmpty()) {
onEmpty()
} else {
dao.saveAll(it.map { user -> user.toUserEntity() })
onSuccess(dao.getAllUsers().map { user -> user.toUserViewable() })
}
}
.doOnSubscribe { onLoading() }
.subscribeOn(Schedulers.io())

View File

@@ -0,0 +1,26 @@
package com.hako.userlist.domain.usecase
import com.hako.base.domain.database.dao.UserDao
import com.hako.base.extensions.wasUpdated
import com.hako.userlist.domain.datasource.UserlistRemoteApi
import com.hako.userlist.model.UserViewable
import com.hako.userlist.model.toUserEntity
import com.hako.userlist.model.toUserViewable
import io.reactivex.Single
import io.reactivex.schedulers.Schedulers
import org.koin.core.KoinComponent
import org.koin.core.get
class SetFavoriteStatus(private val dao: UserDao) {
fun execute(
userId: Int,
favoriteStatus: Boolean,
onError: (userId: Int) -> Unit
) {
Single.fromCallable { dao.saveFavorite(userId, favoriteStatus) }
.subscribeOn(Schedulers.io())
.doOnError { onError(userId) }
.subscribe()
}
}

View File

@@ -12,6 +12,7 @@ import com.hako.base.extensions.observeNonNull
import com.hako.base.extensions.toast
import com.hako.base.extensions.visible
import com.hako.base.navigation.NavigationRouter
import com.hako.base.navigation.ShowFabButton
import com.hako.userlist.model.UserViewable
import com.hako.userlist.viewmodel.UserlistViewmodel
import com.hako.userlist.widget.UserlistAdapter
@@ -22,7 +23,9 @@ import org.koin.android.ext.android.inject
import org.koin.androidx.viewmodel.ext.android.viewModel
import timber.log.Timber
class UserlistFragment : Fragment() {
const val ALBUMLIST_FRAGMENT_BUNDLE_FAVORITES = "ALBUMLIST_FRAGMENT_BUNDLE_FAVORITES"
class UserlistFragment : Fragment(), ShowFabButton {
private val viewModel: UserlistViewmodel by viewModel()
private val listAdapter by lazy { UserlistAdapter() }
@@ -40,7 +43,7 @@ class UserlistFragment : Fragment() {
}
private fun setObservers() {
viewModel.data.observeNonNull(this) {
viewModel.userList.observeNonNull(this) {
it.either(::handleFetchError, ::handleFetchSuccess)
}
@@ -49,17 +52,29 @@ class UserlistFragment : Fragment() {
RequestStatus.Ready -> {
fragment_userlist_error_overlay.gone()
fragment_userlist_loading_overlay.gone()
fragment_userlist_empty_overlay.gone()
}
RequestStatus.Loading -> {
fragment_userlist_error_overlay.gone()
fragment_userlist_loading_overlay.visible()
fragment_userlist_empty_overlay.gone()
}
RequestStatus.Errored -> {
fragment_userlist_error_overlay.visible()
fragment_userlist_loading_overlay.gone()
fragment_userlist_empty_overlay.gone()
}
RequestStatus.Empty -> {
fragment_userlist_error_overlay.gone()
fragment_userlist_loading_overlay.gone()
fragment_userlist_empty_overlay.visible()
}
}
}
viewModel.emptyMessage.observeNonNull(this) {
fragment_userlist_empty_overlay.setLabel(it)
}
}
private fun handleFetchError(throwable: Throwable) {
@@ -79,7 +94,7 @@ class UserlistFragment : Fragment() {
}
onFavoriteClick = {
context.toast(it.userName)
viewModel.updateUserFavoriteStatus(it.id, !it.isFavorite)
}
}
}

View File

@@ -19,10 +19,10 @@ data class UserViewable(
val id: Int,
val realName: String,
val userName: String,
var isFavorite: Boolean = false
var isFavorite: Boolean
)
fun User.toUserEntity() = UserEntity(this.id, this.realName, this.userName, this.email, this.phone, this.website)
fun UserEntity.toUserViewable() = UserViewable(this.id, this.realName, this.userName)
fun UserEntity.toUserViewable() = UserViewable(this.id, this.realName, this.userName, this.isFavorite)

View File

@@ -3,34 +3,65 @@ package com.hako.userlist.viewmodel
import androidx.lifecycle.MutableLiveData
import androidx.lifecycle.ViewModel
import com.hako.base.domain.network.RequestStatus
import com.hako.base.domain.network.RequestStatus.Ready
import com.hako.base.domain.network.RequestStatus.Loading
import com.hako.base.domain.network.RequestStatus.Errored
import com.hako.base.domain.Either
import com.hako.base.domain.network.RequestStatus.*
import com.hako.userlist.domain.usecase.GetFavoriteUsers
import com.hako.userlist.domain.usecase.GetUsers
import com.hako.userlist.domain.usecase.SetFavoriteStatus
import com.hako.userlist.model.UserViewable
import org.koin.core.KoinComponent
import org.koin.core.get
class UserlistViewmodel : ViewModel(), KoinComponent {
val data = MutableLiveData<Either<Throwable, List<UserViewable>>>()
val userList = MutableLiveData<Either<Throwable, List<UserViewable>>>()
val favoriteError = MutableLiveData<Int>()
val emptyMessage = MutableLiveData<String>()
val requestStatus = MutableLiveData<RequestStatus>()
private val getUsers: GetUsers = get()
private val getFavoriteUsers: GetFavoriteUsers = get()
private val setFavoriteStatus: SetFavoriteStatus = get()
fun fetchUsers() {
getUsers.execute(
onSuccess = {
requestStatus.postValue(Ready)
data.postValue(Either.Right(it))
userList.postValue(Either.Right(it))
},
onLoading = {
requestStatus.postValue(Loading)
},
onError = {
requestStatus.postValue(Errored)
data.postValue(Either.Left(it))
userList.postValue(Either.Left(it))
},
onEmpty = {
requestStatus.postValue(Empty)
emptyMessage.postValue("No se encontró ningún usuario")
})
}
fun fetchFavoriteUsers() {
getFavoriteUsers.execute(
onSuccess = {
requestStatus.postValue(Ready)
userList.postValue(Either.Right(it))
},
onError = {
requestStatus.postValue(Errored)
userList.postValue(Either.Left(it))
},
onEmpty = {
requestStatus.postValue(Empty)
emptyMessage.postValue("No tienes favoritos!")
})
}
fun updateUserFavoriteStatus(userId: Int, status: Boolean) {
setFavoriteStatus.execute(userId, status,
onError = {
favoriteError.postValue(it)
})
}
}

View File

@@ -44,18 +44,26 @@ class UserlistAdapter : RecyclerView.Adapter<RecyclerView.ViewHolder>() {
}
}
class UserViewHolder(private val view: View,
private val onItemClick: (UserViewable) -> Unit,
private val onFavoriteClick: (UserViewable) -> Unit) :
class UserViewHolder(
private val view: View,
private val onItemClick: (UserViewable) -> Unit,
private val onFavoriteClick: (UserViewable) -> Unit
) :
RecyclerView.ViewHolder(view) {
fun bind(user: UserViewable) = with(view) {
item_user_card_real_name.text = user.realName
item_user_card_user_name.text = user.userName
if (user.isFavorite) {
item_user_card_like_button.like()
} else {
item_user_card_like_button.dislike()
}
item_user_card_container.setOnClickListener {
onItemClick(user)
}
item_user_card_like_button.setOnClickListener {
item_user_card_like_button.play()
onFavoriteClick(user)
}
}

View File

@@ -35,4 +35,14 @@
app:layout_constraintStart_toStartOf="parent"
app:layout_constraintTop_toTopOf="parent" />
<com.hako.base.widgets.EmptyOverlay
android:id="@+id/fragment_userlist_empty_overlay"
android:layout_width="match_parent"
android:layout_height="match_parent"
android:visibility="gone"
app:layout_constraintBottom_toBottomOf="parent"
app:layout_constraintEnd_toEndOf="parent"
app:layout_constraintStart_toStartOf="parent"
app:layout_constraintTop_toTopOf="parent" />
</androidx.constraintlayout.widget.ConstraintLayout>